gnullvm hosts: add to build-manifest #149503
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
| "i686-pc-windows-msvc", | ||
| "x86_64-pc-windows-gnu", | ||
| "x86_64-pc-windows-gnullvm", | ||
| "x86_64-pc-windows-msvc", |
Member
There was a problem hiding this comment.
Can we reasonably replace this with just "target contains windows in the name" or something like that?
I'd like to drive down the need for these to be here similar to how we moved the tier information into rustc itself.
Member
Author
There was a problem hiding this comment.
It'd have to be something along target.contains("windows") && target.has_host_tools().
I think it should be possible to utilise HOSTS array from your recent PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #147536 and #148751 fixing what I missed there.
After this change
rustup install nightly-x86_64-pc-windows-gnullvm --component rust-mingwshould work.